Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Make scast work with metamagic adept #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

etriebe
Copy link

@etriebe etriebe commented Jul 18, 2023

What Alias/Snippet is this for?

Update scast to work with a different custom counter for meta magic adept

Summary

Fix #36

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • I properly commented my code where appropriate

@etriebe
Copy link
Author

etriebe commented Jul 18, 2023

Questions: How do I test this? Is there a way to get avrae to test with a PR? Do I need to unsubscribe from the existing collection and make my own? This is my first time modifying a github repo and creating a PR for an alias.
What does the cc_out line do on line 71? I'm attempting to make this work with arrays, since technically someone could have metamagic and be metamagic adept (IIRC). If that can't be the case, I'll do an either-or situation.

@Croebh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make !scast work with the sorcery points from the Metamagic Adept feat from TCoE
1 participant