-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some helper methods to the Item Scanner, Movement, Journal and Tiles #18
Conversation
stray #region
Thank you for your Request! As we speak I´m moving to another place and dont have any computer to review your code. I will do this asap I´m able to do so (prolly mid\end August). |
No rush, was to see if there was anyone alive on the other end as much as
anything. Just got back into UO and writing some scripts so I'll probably
have a few more tweaks to add as well over the next month or two.
…On Mon, Jul 30, 2018 at 5:29 PM, Crome696 ***@***.***> wrote:
Thank you for your Request! As we speak I´m moving to another place and
dont have any computer to review your code. I will do this asap I´m able to
do so (prolly mid\end August).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAdaKyirD4izCphK_MI6gM5_Cw6ewEkks5uLrXTgaJpZM4VlFhF>
.
|
Well due close to zero interest i kinda stopped the further development for a while now. I stopped playing uo like a year ago and planned only to develop sdk further. But for some reasons i kinda miss uo. So planning on coming back myself after moving and then i will also update SDK further. Any support and help is appreciated. |
Hah UO is like that, every few years I come back for a couple of months and
get sucked in.
Great project btw, Its a far step forward than cheffe's uo.dll with C# that
i was using last time i got into UO.
…On Tue, Jul 31, 2018 at 12:04 AM, Crome696 ***@***.***> wrote:
Well due close to zero interest i kinda stopped the further development
for a while now. I stopped playing uo like a year ago and planned only to
develop sdk further. But for some reasons i kinda miss uo. So planning on
coming back myself after moving and then i will also update SDK further.
Any support and help is appreciated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABAdaKg5ZkqN_C09dXuxVpjPirxdeJrWks5uLxJ8gaJpZM4VlFhF>
.
|
So i reviewed your commited Changes and request a few changes:
ScriptSDK/Stealth API/Stealth.cs Same as Movinghelper. We should avoid doublecode. Stealth.cs is the raw API and should mirror exact what Stealth expose. so please remove that change there and call it by the original movinghelper functions. Thank you for your submissions and i hope we will see more code by you Cheers Crome |
As per title, just some minor additions to make life easier.