Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple diagrams to be opened #44

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Allow multiple diagrams to be opened #44

merged 8 commits into from
Dec 8, 2023

Commits on Nov 30, 2023

  1. Allow multiple diagrams to be opened

    - Fix TheiaJsonrpcGLSPClient to only have one handler for connection
    - Fix problem with filter with same ID being added multiple times
    
    - Add formatting of CSS files to prettier
    - Centralize ID handling for containers and global IDs
    -- Diagram elements need locally unique IDs
    -- Other elements need globally unique IDs
    
    Fixes #16
    martin-fleck-at committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    4fc24c9 View commit details
    Browse the repository at this point in the history
  2. Updated playwright config to have timeouts for action and navigation …

    …so tests fail on actions i.s.o. timeout.
    harmen-xb committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    409b5cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ce5e47 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    1b74139 View commit details
    Browse the repository at this point in the history
  2. Fix "Property widget starts flashing"

    Problem: We open an entity through the property view. That triggers a
    rebuild of the entity document which triggers an update in all open
    diagrams that have that entity as they have a reference to it. The
    diagram update also resets the selection state in each diagram which
    in turn updates the property view again as it reacts to selection
    changes. This can lead to an update-cycle if there is more than one
    diagram open with the same entity.
    
    Fix: Since the property view reacts to selection changes and updates in
    the diagram trigger such a change, there is no need for the property
    view to listen actually participate in the model lifecycle itself. So
    there is no need to do the open/close since we do not need to listen to
    updates ourselves.
    martin-fleck-at committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a51dce3 View commit details
    Browse the repository at this point in the history
  3. Fix Diagram context menu issue

    - Ensure that the navigator tree always gets a URI of the selected node
    martin-fleck-at committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    73aa596 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Improve update handling between editors

    - Ensure GLSP selection is forwarded again if active editor changes
    - Only update properties if selection of active widget changes
    - Add additional change reason for better update decision in GLSP
    martin-fleck-at committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    9d084d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Added example relationship and diagram to e2e-tests example worspace.

    Added context menu tests on relationship and diagram files in the explorer view.
    harmen-xb committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4dcdc37 View commit details
    Browse the repository at this point in the history