Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for textual expressions in attribute mappings #56

Merged
merged 2 commits into from
May 30, 2024
Merged

Add support for textual expressions in attribute mappings #56

merged 2 commits into from
May 30, 2024

Conversation

martin-fleck-at
Copy link
Collaborator

  • Allow specifying expressions in attribute mappings as string
  • Validate reference expressions '{{expression}}'
  • Provide suggestions for reference expressions
  • Allow attribute mappings to have 0 to n sources (previously 1)

Minor:

  • Guard return value in selection data service for undefined references

@martin-fleck-at
Add support for textual expressions in attribute mappings
4174776 
- Allow specifying expressions in attribute mappings as string
- Validate reference expressions '{{expression}}'
- Provide suggestions for reference expressions
- Allow attribute mappings to have 0 to n sources (previously 1)

Minor:
- Guard return value in selection data service for undefined references
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Unit Test Results

  3 files  ±0   30 suites  ±0   2m 29s ⏱️ -9s
 71 tests ±0   71 ✅ ±0  0 💤 ±0  0 ❌ ±0 
216 runs  ±0  216 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 83e9f60. ± Comparison against base commit f0b6dc8.

♻️ This comment has been updated with latest results.

@harmen-xb
Copy link
Contributor

harmen-xb commented May 24, 2024 •
edited
Loading

@martin-fleck-at

Expressions look good and nice to see the completion working!

Some things:

  • The suggestion in the expression works when we type {{ and press ctrl+space. But when we have {{ with any character after it, like a partial name, it doesn't work.
  • When clicking on a validation error ("Only sources can be ...") it opens the graphical mapping, i.s.o. jumping to the code where the error is. Or jumping to the new-form of the next PBI is also fine.

@martin-fleck-at
PR Feedback
83e9f60 
- Improve handling of auto-completion to allow partial match
- Avoid opening error markers in mapping diagram
@martin-fleck-at
Copy link
Collaborator Author

@harmen-xb I adapted the behavior as you mentioned and now everything should work as expected. Please have another look.

harmen-xb
harmen-xb approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works good now, code also looks good as far as I can check.

@harmen-xb harmen-xb merged commit a7614c4 into main May 30, 2024
5 checks passed
@harmen-xb harmen-xb deleted the feature/textual-expression branch May 31, 2024 12:09
@martin-fleck-at martin-fleck-at restored the feature/textual-expression branch June 3, 2024 19:07
@harmen-xb harmen-xb deleted the feature/textual-expression branch June 6, 2024 11:39
@harmen-xb harmen-xb restored the feature/textual-expression branch June 6, 2024 11:39
@harmen-xb harmen-xb deleted the feature/textual-expression branch June 14, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harmen-xb harmen-xb harmen-xb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martin-fleck-at @harmen-xb