Skip to content

Commit

Permalink
Fix to add RedisLock to handle Announce activity (mastodon#14365)
Browse files Browse the repository at this point in the history
  • Loading branch information
noellabo authored and Mage committed Jan 14, 2022
1 parent 96e0f23 commit 0117b9b
Showing 1 changed file with 25 additions and 14 deletions.
39 changes: 25 additions & 14 deletions app/lib/activitypub/activity/announce.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,32 @@ class ActivityPub::Activity::Announce < ActivityPub::Activity
def perform
return reject_payload! if delete_arrived_first?(@json['id']) || !related_to_local_activity?

original_status = status_from_object
RedisLock.acquire(lock_options) do |lock|
if lock.acquired?
original_status = status_from_object

return reject_payload! if original_status.nil? || !announceable?(original_status)
return reject_payload! if original_status.nil? || !announceable?(original_status)

status = Status.find_by(account: @account, reblog: original_status)
@status = Status.find_by(account: @account, reblog: original_status)

return status unless status.nil?
return @status unless @status.nil?

status = Status.create!(
account: @account,
reblog: original_status,
uri: @json['id'],
created_at: @json['published'],
override_timestamps: @options[:override_timestamps],
visibility: visibility_from_audience
)
@status = Status.create!(
account: @account,
reblog: original_status,
uri: @json['id'],
created_at: @json['published'],
override_timestamps: @options[:override_timestamps],
visibility: visibility_from_audience
)

distribute(status)
status
distribute(@status)
else
raise Mastodon::RaceConditionError
end
end

@status
end

private
Expand Down Expand Up @@ -54,4 +61,8 @@ def requested_through_relay?
def reblog_of_local_status?
status_from_uri(object_uri)&.account&.local?
end

def lock_options
{ redis: Redis.current, key: "announce:#{@object['id']}" }
end
end

0 comments on commit 0117b9b

Please sign in to comment.