Add improving performance with current limits article #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhall-ctre
requested changes
Apr 6, 2024
source/docs/api-reference/device-specific/talonfx/talonfx-control-intro.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
bhall-ctre
reviewed
Apr 6, 2024
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
|
Something else to mention, stator current limits are effective at limiting motor temperature. |
I'm aware that they are, but could you give a practical example of this I can incorporate? |
I don't remember which current is controlled in Vex's locked rotor tests, but a locked rotor test would be the easiest way to demonstrate the temperature rise for various current limits. |
|
Unless someone else grabs the data, I don't have the equipment for it. So I might just add a blurb and put having a practical example in the backlog. |
bhall-ctre
reviewed
Apr 6, 2024
source/docs/api-reference/device-specific/talonfx/talonfx-control-intro.rst
Outdated
Show resolved
Hide resolved
bhall-ctre
reviewed
Apr 6, 2024
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
bhall-ctre
force-pushed
the
add-currentlimit-docs
branch
from
eb9da59
to
fb7dfec
Compare
bhall-ctre
force-pushed
the
add-currentlimit-docs
branch
from
1883ebd
to
c6aa391
Compare
bhall-ctre
requested changes
Apr 9, 2024
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
bhall-ctre
requested changes
Apr 9, 2024
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
bhall-ctre
force-pushed
the
add-currentlimit-docs
branch
from
76b0bd7
to
bca1154
Compare
bhall-ctre
approved these changes
Apr 10, 2024
bhall-ctre
approved these changes
Apr 10, 2024
CoryNessCTR
requested changes
Apr 10, 2024
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
source/docs/hardware-reference/talonfx/improving-performance-with-current-limits.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Cory <cnessctre@gmail.com>
bhall-ctre
force-pushed
the
add-currentlimit-docs
branch
from
2db4a5a
to
0204c8c
Compare
CoryNessCTR
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.