Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

WIP: Bili Dist Build #126

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: Bili Dist Build #126

wants to merge 7 commits into from

Conversation

BrockReece
Copy link
Collaborator

This uses bili.js to transpile dist ready files and points the package.json at these new files.

This should address issues we have been having with babel and webpack configs #112
If you want to help me test this, you can install this new version from NPM and leave a comment beneath with any feedback. @MackAttack26 @steven87vt

npm install vue-full-calendar@bili
// or yarn
yarn add vue-full-calendar@bili

@steven87vt
Copy link

Hey @BrockReece

Modified my wepack.config file back to what it was, found the @bili build number on npm and modified my package.json file to mach. However I did try scoping it with @bili but it was not found:

package.json

"vue-full-calendar": "2.7.0-0",

webpack.config.js

rules: [
    {
        test: /\.vue$/,
        include: [
            /ClientApp/,
            //path.resolve(__dirname, 'node_modules/vue-full-calendar'),
        ],
        use: 'vue-loader'
    },

Before I ran my local build i went and deleted the existing vue-fullcalendar directory from node_modules and everything ran fine. So far it appears that fixed the issue we were originally discussing #112

@steven87vt
Copy link

Just remembered about babel-preset-env, I removed that as well, cleared my npm cache and deleted it from node_modules. After rebuild everything is working.

@TWainwright
Copy link

Hello,

I work with Steven and have been trying to get dragging external events working with vue-fullcalendar. After some testing I have found that it works fine with build 2.6.1, but not 2.7.0-0. We have a sandbox here which shows it working. If you make the one change in package.json to update the vue-fullcalendar version from 2.6.1 to 2.7.0-0 dragging external events no longer works. Looking through the commits I can't see what might be the cause. I would assume something with bili or bable. Please let us know if you get a chance to look at this.

Thanks,
Ted

@BrockReece
Copy link
Collaborator Author

Hmm, I wonder if this is anything to do with the fact that it includes jQuery in the bundle and I am guessing have imported another version of jQuery?

@TWainwright
Copy link

I've tried a number of different ways. Importing jquery-ui itself or with draggable just doesn't work. The only way I can get draggable working is with jquery-ui-bundle, which was suggested on other message boards. Also I've read other comments about the multiple jQuery issues with FullCalendar. You can see in App.vue I'm doing:

import jquery from 'jquery'
window.$ = window.jQuery = jquery;

which is the suggested solution. I have 2.6.1 working locally without the need for the second line though.

@BrockReece
Copy link
Collaborator Author

I have updated the package.json to include a module file as well as the main file. The difference being that the main file includes it's own version of jQuery where as the module file should require as per anywhere else in your project.

Webpack, Rollup etc should use the module by default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants