Merge pull request #561 from okaestne/clang-warnings

Fix warnings generated by clang++
CrowCpp · Nov 30, 2022 · dedfd63 · dedfd63
2 parents 84ec783 + 5e19641
commit dedfd63
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/include/crow/app.h b/include/crow/app.h
@@ -305,7 +305,7 @@ namespace crow
                             if (static_dir_[static_dir_.length() - 1] != '/')
                                 static_dir_ += '/';
 
-                            bp->new_rule_tagged<crow::black_magic::get_parameter_tag(CROW_STATIC_ENDPOINT)>(CROW_STATIC_ENDPOINT)([bp, static_dir_](crow::response& res, std::string file_path_partial) {
+                            bp->new_rule_tagged<crow::black_magic::get_parameter_tag(CROW_STATIC_ENDPOINT)>(CROW_STATIC_ENDPOINT)([static_dir_](crow::response& res, std::string file_path_partial) {
                                 utility::sanitize_filename(file_path_partial);
                                 res.set_static_file_info_unsafe(static_dir_ + file_path_partial);
                                 res.end();

diff --git a/include/crow/http_response.h b/include/crow/http_response.h
@@ -139,7 +139,7 @@ namespace crow
             set_header("Content-Type", value.content_type);
         }
         response(int code, returnable&& value):
-          code(code), body(std::move(value.dump()))
+          code(code), body(value.dump())
         {
             set_header("Content-Type", std::move(value.content_type));
         }

diff --git a/include/crow/middlewares/cookie_parser.h b/include/crow/middlewares/cookie_parser.h
@@ -225,7 +225,7 @@ namespace crow
             }
 
         private:
-            friend class CookieParser;
+            friend struct CookieParser;
             std::vector<Cookie> cookies_to_add;
         };
 

diff --git a/include/crow/middlewares/session.h b/include/crow/middlewares/session.h
@@ -335,7 +335,7 @@ namespace crow
             }
 
         private:
-            friend class SessionMiddleware;
+            friend struct SessionMiddleware;
 
             void check_node()
             {