replaced 0.3 with master in master branch #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to more accurately distinguish where a crow build is coming from (it used to be the latest release, which is not the best idea)
mrozigor
reviewed
Jun 28, 2021
| @@ -120,7 +120,7 @@ namespace crow | |||
| return *this; | |||
| } | |||
|
|
|||
| ///Set the server name (default Crow/0.3) | |||
| ///Set the server name (default Crow/master) | |||
There was a problem hiding this comment.
I think that you can remove info about default value. Or change to something like Crow/<VERSION>
There was a problem hiding this comment.
My bad, I just changed every 0.3 to master without looking much.
| @@ -360,7 +360,7 @@ namespace crow | |||
| private: | |||
| uint16_t port_ = 80; | |||
| uint16_t concurrency_ = 1; | |||
| std::string server_name_ = "Crow/0.3"; | |||
| std::string server_name_ = "Crow/master"; | |||
There was a problem hiding this comment.
Maybe create new header with some constexpr VERSION_STRING and use it here and in http_server.h. And then change this version from master to appropriate in cmake script on deploy/package target? I could prepare something like this maybe tomorrow if you want :)
|
replaced with #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to more accurately distinguish where a crow build is coming from (it used to be the latest release, which is not the best idea)
It's worth mentioning that the changes here need to be made for each release