Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing http status codes added #227

Merged
merged 2 commits into from
Sep 30, 2021
Merged

missing http status codes added #227

merged 2 commits into from
Sep 30, 2021

Conversation

Zhavok92
Copy link

No description provided.

@The-EDev
Copy link
Member

I'm sorry for the late response, I was occupied with another PR, I have a few concerns about some of the codes added, I'll list them in the next comment.

Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked into the added codes, here are my observations:

  • 102 - webdav only

  • 103 - seemingly no compatibility (not sure what to do about it)

  • 207, 208 - Webdav again

  • 226 - Crow doesn't support delta encoding by default (just a note)

  • 305, 306 - Deprecated (definitely remove)

  • 402, 425 - Seems experimental (not sure what to do about them)

  • 406 - Crow doesn't support Server-driven content negotiation by default (just a note)

  • 408 - Crow shuts down connections without sending this, will require changes to connection.h (definitely remove)

  • 411, 412, 414, 421, 426, 431 - They feel like they shouldn't be sent by a user, rather by crow itself.. which crow doesn't send currently (suggest removal)

  • 418 - Crow doesn't support coffee-scheme unfortunately (definitely remove)

  • 422, 423, 424 - Webdav

  • 504, 505 - They feel like they shouldn't be sent by a user, rather by crow itself.. which crow doesn't send currently (suggest removal)

  • 507, 508 - Webdav once more

  • 510 - Crow doesn't support HTTP extension (suggest removal)

  • 511 - usually generated by proxies, crow is not meant to be a proxy (definitely remove)

For webdav codes, I suggest removing them since Crow neither supports webdav nor webdav HTTP methods, both can be added in a later PR if needed.

@Zhavok92
Copy link
Author

Thanks for response, I have removed the changes you mentioned.

@The-EDev The-EDev merged commit c38e114 into CrowCpp:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants