Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vcpkg.json to work with those building on linux #330

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

Borwe
Copy link
Contributor

@Borwe Borwe commented Feb 3, 2022

Fix issue at #329

@CrowCpp CrowCpp deleted a comment from crow-clang-format bot Feb 3, 2022
@The-EDev
Copy link
Member

The-EDev commented Feb 3, 2022

clang format not relevant, shouldn't even generate a report since the file isn't a C/C++ file.

Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though I've rarely used VCPKG so I'd appreciate @luca-schlecker's opinion.

@The-EDev The-EDev linked an issue Feb 8, 2022 that may be closed by this pull request
@The-EDev The-EDev merged commit e958cef into CrowCpp:master Feb 8, 2022
@luca-schlecker
Copy link
Collaborator

I'm sorry for taking so long, this is looking good and works as intended, just to reassure you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openssl in VCPKG
3 participants