Fix some valgrind reported issues #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes some memory leaks. also remove unused `get_size` method.
mrozigor
approved these changes
Nov 8, 2022
|
Is there anything prohibiting this PR to be accepted? I've hit mem and connection leaks as well and I'd be interested to see this merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two smaller issues that I found using valgrind:
routing/Trie: use object references instead of raw pointers
This way, we don't need to free the
Triewhen stopping the program (what we don't do right now).Also remove unused
get_sizemethod and simplify code a bit.http_connection: initialize
task_id_The former change addresses one of the leaks mentioned in #546. The other one, that is caused in
do_acceptby creating newConnectionobjects for every request seems to be harder to solve. This one should really be addressed, as it leaks around 5KB for every request.