Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake install rules #80

Merged
merged 5 commits into from Dec 6, 2020
Merged

cmake install rules #80

merged 5 commits into from Dec 6, 2020

Conversation

ayaankhan98
Copy link
Contributor

@ayaankhan98 ayaankhan98 commented Dec 5, 2020

closes #68
To install crow globally, one should run make install instead of make after cmake .. this will automatically copy crow_all.h to /usr/local/include. Thus making it available gloablly

@ayaankhan98
Copy link
Contributor Author

ayaankhan98 commented Dec 5, 2020

This is what i understand after reading discussion on #68. Let me know if i am missing something or if this is fine i will add this in documentation too.

@The-EDev
Copy link
Member

The-EDev commented Dec 5, 2020

@ayaankhan98
Copy link
Contributor Author

ayaankhan98 commented Dec 5, 2020

If you want to link an issue in such a way that this PR closes it, you should look at https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

yes i know this already, The reason i type it there is because i cannot link issue from the right cloumn of the web page. i don't know there may be some access rights issue which is not allowing me to link issue from there.

Capture

Linked Issue option is disabled for me

@The-EDev
Copy link
Member

The-EDev commented Dec 5, 2020

Yes, you can link in issue by typing closes #68 without needing the linked issues menu, whether you type that or add it from the menu, it should have the same effect

@ayaankhan98
Copy link
Contributor Author

Yes, you can link in issue by typing closes #68 without needing the linked issues menu, whether you type that or add it from the menu, it should have the same effect

Thanks! got it.

The-EDev
The-EDev previously approved these changes Dec 5, 2020
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems to work fine.
You can add the documentation if you want or leave it to me.
If you choose to do it, you should explain the make install command as an alternative to make in line 97 of docs/getting_started/setup.md and explain what it does.

@ayaankhan98
Copy link
Contributor Author

Code seems to work fine.
You can add the documentation if you want or leave it to me.
If you choose to do it, you should explain the make install command as an alternative to make in line 97 of docs/getting_started/setup.md and explain what it does.

okay, will do that soon, once i do that you can thereafter give suggestions to improve upon that.

docs/getting_started/setup.md Outdated Show resolved Hide resolved
docs/getting_started/setup.md Outdated Show resolved Hide resolved
docs/getting_started/setup.md Outdated Show resolved Hide resolved
docs/getting_started/setup.md Outdated Show resolved Hide resolved
docs/getting_started/setup.md Outdated Show resolved Hide resolved
@The-EDev The-EDev merged commit 0f5f979 into CrowCpp:master Dec 6, 2020
@ayaankhan98 ayaankhan98 deleted the install-rules branch December 6, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible make install rule for cmake ?
2 participants