Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EagleEye exact keyword matching #383

Merged
merged 15 commits into from Jan 9, 2023
Merged

Conversation

mariobalca
Copy link
Contributor

@mariobalca mariobalca commented Dec 23, 2022

Changes proposed ✍️

  • Add eagle eye exact match tooltip

Screenshots (front-end changes only)

Screenshot 2022-12-23 at 17 20 24

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@mariobalca mariobalca added the Improvement Created by Linear-GitHub Sync label Dec 23, 2022
@mariobalca mariobalca self-assigned this Dec 23, 2022
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariobalca mariobalca force-pushed the enhancement/eagle-eye-exact-match branch from 6b266e6 to ac16e2f Compare January 5, 2023 01:36
@@ -33,7 +33,12 @@ export class EagleEyeService {

static async populate(keywords) {
const data = {
keywords
exactKeywords: keywords.filter((k) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎········

Suggested change
exactKeywords: keywords.filter((k) => {
exactKeywords: keywords
.filter((k) => {

@@ -33,7 +33,12 @@

static async populate(keywords) {
const data = {
keywords
exactKeywords: keywords.filter((k) => {
return k[0] === '"' && k[k.length - 1] === '"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ··

Suggested change
return k[0] === '"' && k[k.length - 1] === '"'
return k[0] === '"' && k[k.length - 1] === '"'

keywords
exactKeywords: keywords.filter((k) => {
return k[0] === '"' && k[k.length - 1] === '"'
}).map((s) => s.replaceAll('"', '')),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }) with ··})⏎········

Suggested change
}).map((s) => s.replaceAll('"', '')),
})
.map((s) => s.replaceAll('"', '')),

@joanreyero joanreyero changed the title Add eagle eye exact match tooltip EagleEye exact keyword matching Jan 5, 2023
@joanreyero joanreyero merged commit b28de43 into main Jan 9, 2023
@joanreyero joanreyero deleted the enhancement/eagle-eye-exact-match branch January 9, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants