Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent fail on secret #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomRyan-321
Copy link
Contributor

@TomRyan-321 TomRyan-321 commented Oct 22, 2023

Temporary disable fail on secret detected until better path based exception handling implemented. Currently high match rates when importing AWS boto sdk and similar libraries which are impractical for users to clean up manually.

Some samples being detected
dist-packages/botocore/data/iam/2010-05-08/examples-1.json
dist-packages/botocore/data/sts/2011-06-15/examples-1.json
dist-packages/botocore/data/cloud9/2017-09-23/examples-1.json

@ffalor
Copy link
Contributor

ffalor commented Oct 25, 2023

Perhaps a flag --ignore-secrets to disable this would be better for folks who aren't running into this specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants