chore(internal): setup turborepo #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
try-turborepo
branch
from
6661ee0
to
a44e134
Compare
Preview URLsGH Env: preview |
NullVoxPopuli
force-pushed
the
try-turborepo
branch
14 times, most recently
from
74c0885
to
90c62de
Compare
NullVoxPopuli
force-pushed
the
try-turborepo
branch
from
ee63b53
to
9af1115
Compare
Deploying with
|
| Latest commit: |
9af1115
|
| Status: | 🚫 Build failed. |
NullVoxPopuli
force-pushed
the
try-turborepo
branch
2 times, most recently
from
d2f60ab
to
0ff7b7b
Compare
NullVoxPopuli
force-pushed
the
try-turborepo
branch
from
86a75a1
to
12b2b6f
Compare
|
This is a squashed commit, for easier rebasing and conflict resolution. Previous topics in now hidden commits: chore(turbo): try suggestion from: vercel/turbo#2306 (comment) -- seems like resync finishes too early, and we need it to run specifically after the library build chore(turbo, ci): setup turbo before pnpm install chore(turbo): try cache-hit chore(scripts): tidy up the start meta-script
NullVoxPopuli
force-pushed
the
try-turborepo
branch
from
12b2b6f
to
ae38789
Compare
This was referenced Feb 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to explore
Before:
After:
at the time of collecting these numbers, a lot of time is wasted due to excessive
pnpm iruns due to the below linked issue.Also, the
setup-nodeaction takes about 18-30s for every job, so if everything was instant, this step of each job would total to 8-10m -- combined with dependencies in general taking 10s, I'm not sure how much more room for improvement there is (aside from the bug getting fix (linked below))after a
pnpm install, can we have X "just work"?pnpm start(watch mode all the things)pnpm test(cli only, no server)until the below issue is a fixed, a
pnpm installis required after the initialpnpm installto re-sync pnpm.Once done, the following is observed:
pnpm testpnpm start- works, no turbo needed, becauseprepareran after installThings learned along the way: