Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ ENH ] Accept dashed base url specifiers #580

Closed
jshcodes opened this issue Mar 4, 2022 · 0 comments · Fixed by #584
Closed

[ ENH ] Accept dashed base url specifiers #580

jshcodes opened this issue Mar 4, 2022 · 0 comments · Fixed by #584
Assignees
@jshcodes
Labels
authentication Issues or questions regarding authentication enhancement 🌟 New feature or request SDK usage General SDK usage issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Mar 4, 2022

Describe the enhancement
Allow for specifying base_url using dashed specifiers. (Examples: us-1, eu-1, us-2, us-gov-1)

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: <= 1.0.5

Additional context
Thanks to @jhseceng for suggesting this enhancement.
@jshcodes jshcodes added enhancement 🌟 New feature or request authentication Issues or questions regarding authentication SDK usage General SDK usage issues and questions labels Mar 4, 2022
@jshcodes jshcodes self-assigned this Mar 5, 2022
jshcodes added a commit that referenced this issue Mar 5, 2022
@jshcodes
Allow dashed base URL specifiers. Closes #580.
43228e4
jshcodes added a commit that referenced this issue Mar 9, 2022
@jshcodes
Allow dashed base URL specifiers. Closes #580.
eb61cf9
@jshcodes jshcodes mentioned this issue Mar 9, 2022
Merged
2 tasks
jshcodes added a commit that referenced this issue Mar 10, 2022
@jshcodes
Allow dashed base URL specifiers. Closes #580.
0c472f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
authentication Issues or questions regarding authentication enhancement 🌟 New feature or request SDK usage General SDK usage issues and questions
Projects
None yet
Milestone
No milestone
1 participant
@jshcodes