Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream error "json: invalid number literal, trying to unmarshal "\"DOMAIN_COMPROMISE\"" into Number" #215

Closed
kliao365 opened this issue Apr 7, 2022 · 0 comments · Fixed by #216
Closed

stream error "json: invalid number literal, trying to unmarshal "\"DOMAIN_COMPROMISE\"" into Number" #215

kliao365 opened this issue Apr 7, 2022 · 0 comments · Fixed by #216

Comments

@kliao365
Copy link

kliao365 commented Apr 7, 2022

Hi,

It looks like the fix Allow string and uint values in Event.IncidentType by isimluk · Pull Request #206 · CrowdStrike/gofalcon didn't completely resolve the issue stream error "json: cannot unmarshal string into Go struct field Event.event.IncidentType of type uint64" · Issue #205 · CrowdStrike/gofalcon. The Event.event.IncidentType could be some string literals that can not be unmarshalled into json.Number type. Your help to address this issue is much appreciated.

Kevin
isimluk added a commit to isimluk/gofalcon that referenced this issue Apr 8, 2022
@isimluk
Streaming API: Accept string values, when uint64 is expected
203e1f2 
Fixes: CrowdStrike#215

Addressing:
stream error "json: invalid number literal, trying to unmarshal "\"DOMAIN_COMPROMISE\"" into Number"
@isimluk isimluk mentioned this issue Apr 8, 2022
Merged
@kliao365 kliao365 mentioned this issue Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Streaming API: Accept string values, when uint64 is expected isimluk/gofalcon
1 participant
@kliao365