Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial falcon_supported_kernels example #104

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Initial falcon_supported_kernels example #104

merged 4 commits into from
Aug 28, 2023

Conversation

mikemadden42
Copy link
Collaborator

No description provided.

makr11st
makr11st approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@makr11st makr11st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think a good next step would be to make distro and arch optional and fetch possible options from the API.

Also if we can enable pagination or make the limit per page configurable (optional) it would be nice.

@mikemadden42 mikemadden42 merged commit f894145 into CrowdStrike:main Aug 28, 2023
23 checks passed
@mikemadden42 mikemadden42 deleted the add-falcon_supported_kernels branch August 28, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makr11st makr11st makr11st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikemadden42 @makr11st