Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant CI steps, add missing build and build release steps #106

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ env:
CARGO_TERM_COLOR: always

on:
push:
branches: [ main ] # this should be blocked entirely!
workflow_dispatch:
pull_request:

jobs:
Expand Down
60 changes: 0 additions & 60 deletions .github/workflows/ci.yaml

This file was deleted.

44 changes: 42 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,31 @@ on:
pull_request:

jobs:
required:
build:
runs-on: ubuntu-latest
name: ubuntu / ${{ matrix.toolchain }}
name: Build Ubuntu / ${{ matrix.toolchain }}
strategy:
matrix:
toolchain: [stable, beta]
steps:
- uses: actions/checkout@v3
with:
submodules: true
- name: Install ${{ matrix.toolchain }}
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.toolchain }}
- name: cargo generate-lockfile
if: hashFiles('Cargo.lock') == ''
run: cargo generate-lockfile
- name: cargo build
run: cargo build
- name: cargo build release
run: cargo build --release

test:
runs-on: ubuntu-latest
name: Test Ubuntu / ${{ matrix.toolchain }}
strategy:
matrix:
toolchain: [stable, beta]
Expand All @@ -32,6 +54,20 @@ jobs:
- name: cargo test --doc
run: cargo test --locked --all-features --doc | grep 'Missing FALCON_CLIENT_ID environment variable.'

nightly:
name: Rust nightly
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@nightly
with:
components: rust-src
- run: |
cargo test --lib --bins --examples --benches
- run: |
# We expect doc example to fail without Falcon Credentials
cargo test --doc | grep 'Missing FALCON_CLIENT_ID environment variable.'

minimal:
runs-on: ubuntu-latest
name: ubuntu / stable / minimal-versions
Expand Down Expand Up @@ -70,5 +106,9 @@ jobs:
- name: cargo generate-lockfile
if: hashFiles('Cargo.lock') == ''
run: cargo generate-lockfile
- name: cargo build
run: cargo build
- name: cargo build release
run: cargo build --release
- name: cargo test
run: cargo test --locked --all-features --all-targets