Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing negation in the pagination of spotlight example #109

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add missing negation in the pagination of spotlight example #109

merged 1 commit into from
Aug 31, 2023

Conversation

makr11st
Copy link
Collaborator

I missed the negation of the pagination which caused the example to fetch only the first page and then stop.

mikemadden42
mikemadden42 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makr11st makr11st merged commit df35389 into CrowdStrike:main Aug 31, 2023
22 checks passed
@makr11st makr11st deleted the bugfix/spotlight_example_pagination_missing branch August 31, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemadden42 mikemadden42 mikemadden42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makr11st @mikemadden42