Adds Suitcase Device module #94

Landric · 2024-01-13T19:59:38Z

Adds "Suitcase Device" module; spawns a ruggedised laptop with a countdown towards a customisable event (small/large/nuclear explosion, smoke, etc).

Device is also "killed" at the end of the countdown, so can be paired with the On Death module to add custom code, etc.

Can be disarmed (optionally, only by Engineer/EOD tech) after a customisable amount of time.

Crowdedlight · 2024-01-17T00:29:31Z

Will look through it soon. Just to confirm before I do. Do you think it works in MP between clients that do not have the mod loaded? (The server would not have this mod loaded as a requirement, as its clientside).
While I assume the execute code would work as I believe it piggyback on ZENs functions, what about the texture, sound and countdown?

You can let me know if you want to test it at some point and we'll get someone to restart the server without whitelist so you can test it.

Landric · 2024-01-17T11:01:09Z

Do you think it works in MP between clients that do not have the mod loaded? (The server would not have this mod loaded as a requirement, as its clientside)

Believe so; but I'd like to test to be sure.

While I assume the execute code would work as I believe it piggyback on ZENs functions, what about the texture, sound and countdown?

The texture just uses setObjectTextureGlobal and the countdown just relies on severTime rather than other crowsZA functions. For the sound, I do make the assumption that if crowsEW installed on the zeus's client, it's installed on all other clients+server (which I think is required for crowsEW?), but that may not be a safe assumption if the community doesn't have a mod whitelist.

You can let me know if you want to test it at some point and we'll get someone to restart the server without whitelist so you can test it.

That'd be good - particularly if someone can join without CZA or CEW loaded

Crowdedlight · 2024-01-17T11:30:11Z

The texture just uses setObjectTextureGlobal and the countdown just relies on severTime rather than other crowsZA functions. For the sound, I do make the assumption that if crowsEW installed on the zeus's client, it's installed on all other clients+server (which I think is required for crowsEW?), but that may not be a safe assumption if the community doesn't have a mod whitelist.

True, EWAR requires everyone to load it. So that should be a fair assumption. Not sure if you have the module only loaded if EWAR is loaded too?

Landric · 2024-01-17T12:02:03Z

Not sure if you have the module only loaded if EWAR is loaded too?

The rest of the module should work fine - the EWAR dependency is only checked to play a soundfile when the device is disarmed.

Crows-Zeus-Additions/addons/misc/functions/fnc_suitcaseNukeZeus.sqf

Lines 172 to 178 in a829032

    
           { 
        
               _target setVariable [QGVAR(suitcaseNuke_isArmed), false, true]; 
        
               if (isClass(configFile >> "CfgPatches" >> "crowsEW_sounds")) then { 
        
                   [getPos _target, 200, "device_disarmed", 2] call crowsEW_sounds_fnc_playSoundPos; 
        
                   [getPos _target, 200, "futuristic_machine_turn_off", 2] call crowsEW_sounds_fnc_playSoundPos; 
        
               }; 
        
           },

(Now I look at it, that might need to be getPosASL)

Crowdedlight · 2024-02-03T18:24:15Z

addons/misc/functions/fnc_suitcaseNukeZeus.sqf

+
+
+    // Timer code
+    // TODO: move to server to avoid problems if zeus crashes?


Sadly can't assume server would have this loaded as clientside only. So no real way to offload custom functions easily. Only option would remoteExec a spawn, but unsure how it transfers the code in the spawn.

Yes, remoteExec was the approach I was considering, but that brings its own set of issues. Probably best to leave it on the zeus's machine; but worth testing exactly what happens if the zeus leaves/disconnects (presumably the code just stops running and the device becomes inert - but it might be nice if there was a way of maintaining it or cleaning it up!)

What about an EH for if/when the object changes locality?

What about an EH for if/when the object changes locality?

on which client would you register said EH? It won't fire on the Zeus' machine if already left ;-)

Hmm, does ZEN or CBA not have a event you can call that spawns or executes code? Might be able to piggy-back on that to send code to run on server. Like the execute_code module and sending the code as string? Not pretty, but this mod require CBA and ZEN loaded on server, so it should be available?

on which client would you register said EH? It won't fire on the Zeus' machine if already left ;-)

If registered on all machines, it'll only fire on the one it was transferred from (except they've left), and whichever one it moves to (which could in theory take over the timer/activation)

I'm not sure its a good idea...

Hmm, does ZEN or CBA not have a event you can call that spawns or executes code?

Maybe; the reason not to do a straight-up remoteExec is because some servers/clients will block use of call with arbitrary code, and I'd be surprised if CBA let you get around that

Maybe; the reason not to do a straight-up remoteExec is because some servers/clients will block use of call with arbitrary code, and I'd be surprised if CBA let you get around that

Pretty sure CBA gets around that, as you would send a CBA_EVENT which is received by a CBA_LISTENER on the other side. So its not a remoteExec. In general I believe I have seen places with disallowed RemoteExec work with CBA events instead.

Although not completely sure about the underlying tech used for the actual communication.

addons/misc/functions/fnc_suitcaseNukeZeus.sqf

Crowdedlight · 2024-02-03T18:46:09Z

addons/misc/functions/fnc_suitcaseNukeZeus.sqf

+            "Defuse Device",
+            "\a3\ui_f_oldman\data\IGUI\Cfg\holdactions\repair_ca.paa",
+            "\a3\ui_f_oldman\data\IGUI\Cfg\holdactions\repair_ca.paa",
+            format ["(_this distance _target < 3) and (alive _target) and _target getVariable [""crowsza_misc_suitcaseNuke_isArmed"", false]%1", _condition],


please use QGVAR(suitcaseNuke_isArmed) as that will automatically add the prefixes and put it in quotes. I think you can even do:

QUOTE((_this distance _target < 3) and (alive _target) and _target getVariable [QGVAR(crowsza_misc_suitcaseNuke_isArmed), false]%1)

I ran into an issue doing that (I think it may have been in an earlier PR) where using setVariable inside a QUOTE caused some odd behaviour when it hit the comma; I'll double check on that and see if I can clean this up!

Okay, so:

QUOTE((_this distance _target < 3) and (alive _target) and _target getVariable [QQGVAR(suitcaseNuke_isArmed), false]) fails to be processed - the QUOTE(...) gets replaced with an empty string.

QUOTE((_this distance _target < 3) and (alive _target) and (_target getVariable [QQGVAR(suitcaseNuke_isArmed), false])) fails as well - the , before false gets removed from the processed string

QUOTE((_this distance _target < 3) and (alive _target) and _target getVariable [QQGVAR(suitcaseNuke_isArmed)]) gets processed just fine, but I'd rather be explicit about what the default behaviour is

...but doing #define COMMA , and then

QUOTE((_this distance _target < 3) and (alive _target) and (_target getVariable [QQGVAR(suitcaseNuke_isArmed) COMMA false])) sorts it

Might be needed to use ARR macro for the array?

https://discord.com/channels/976165959041679380/1039189045655392389/1204464769373835295 (Ace Discord)

But I also saw this lately. Is that the same thing you are running into?

Oh, yeah, looks like exactly that issue - spooky. ARR might fix it, will try

addons/misc/functions/fnc_suitcaseNukeZeus.sqf

Crowdedlight · 2024-02-03T18:52:55Z

addons/misc/functions/fnc_suitcaseNukeZeus.sqf

+
+private _controls = [
+    // TODO: size of slider makes it very difficult to be precise - replace with (parsed) text?
+    ["SLIDER", ["Timer", "How long until the device activates in MM:SS"], [1, 30*60, 5*60, {[_this, "MM:SS"] call BIS_fnc_secondsToString}]],


would multiplying values with a factor 10 or 100 and then multiply with 0.1 or 0.01 when you get the input, make it better?
Or set it so minimum step-size would be 10 seconds. So every tick on the slider is 10s. Or 5, etc. Might be easier to use?

Minimum step is probably the best approach.

But the main issue is the wide range of times you might want to set (possibly even above what the max value currently is - I can definitely image scenarios where zeus says "you have one hour to find the device, go!")

Having typed that out, I think I'm inclined to lean towards a text box with a HH:MM:SS format

On that note - might be useful to have an additional module (or when the current module is reapplied to an existing "device"), that allows the user to pause/restart/adjust the countdown

That is fair point. I hadn't thought of a zeus going "you have 1 hour" as usually with zeus, that period would be way too long. Too many things able to go wrong or arma being arma, with players loosing time and the timer "strictly" would need to be paused or extended.

But could open up for some extra zeus options. Like time-acceleration on 1, and use ingame time, to say that they need to be in position at XX time, as then this or that would happen.

In that case HH::MM::SS is likely best.

Like time-acceleration on 1...

Oooh, hadn't even considered whether it should be affected by time acceleration. Probably not?

I would say not. Makes it too difficult for Zeus. Imagine forgetting you had 10x acceleration on and putting down a 10s countdown for players. Instantly effect happens. Better to keep it to irl time. (As so far the human players don't experience a 30x acceleration, as the computer does ;-)

On that note - might be useful to have an additional module (or when the current module is reapplied to an existing "device"), that allows the user to pause/restart/adjust the countdown

Ugh, now I'm dealing with race conditions! 😅

addons/misc/functions/fnc_suitcaseNukeZeus.sqf

Plus some bug fixes and comment cleanup

Crowdedlight · 2024-06-02T17:25:48Z

Whats the status here? Need another review? Trying to figure out if you are waiting on me, or just to have more free time yourself ;-)

Landric · 2024-06-03T08:11:44Z

I think we're just waiting on a server-test to shake out any locality issues!

Fix EW loaded check for server

Landric added 5 commits January 13, 2024 19:55

Adds Suitcase Device module

01e12c5

Add comment

fac9d85

Add design comment

6014da2

Bugfix and QoL change

7f0188c

Renamed variable, added missing condition

a829032

Landric and others added 2 commits January 20, 2024 20:18

Update disarm code

a54edaf

Add todo

028118d

Crowdedlight reviewed Feb 3, 2024

View reviewed changes

addons/misc/functions/fnc_suitcaseNukeZeus.sqf Outdated Show resolved Hide resolved

Landric added 5 commits February 6, 2024 21:14

Macro'd many things

47aa1e8

Plus some bug fixes and comment cleanup

Add more effects, including EMP

652437d

Replace spawn with PFEH

d6b8a7e

Minimum-step timer slider

3dd7ee7

Allow modification of existing devices

5bb881b

Update fnc_createSuitcaseNuke.sqf

389839d

Fix EW loaded check for server

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Suitcase Device module #94

Adds Suitcase Device module #94

Landric commented Jan 13, 2024 •

edited

Crowdedlight commented Jan 17, 2024

Landric commented Jan 17, 2024 •

edited

Crowdedlight commented Jan 17, 2024

Landric commented Jan 17, 2024 •

edited

Crowdedlight Feb 3, 2024

Landric Feb 6, 2024

Landric Feb 6, 2024

Crowdedlight Feb 7, 2024

Landric Feb 7, 2024 •

edited

Crowdedlight Feb 7, 2024

Crowdedlight Feb 3, 2024

Landric Feb 6, 2024

Landric Feb 6, 2024 •

edited

Landric Feb 6, 2024

Crowdedlight Feb 7, 2024

Landric Feb 7, 2024

Crowdedlight Feb 3, 2024

Landric Feb 6, 2024 •

edited

Landric Feb 7, 2024

Crowdedlight Feb 7, 2024

Landric Feb 7, 2024

Crowdedlight Feb 7, 2024

Landric Feb 8, 2024

Crowdedlight commented Jun 2, 2024

Landric commented Jun 3, 2024



		// Timer code
		// TODO: move to server to avoid problems if zeus crashes?

Adds Suitcase Device module #94

Are you sure you want to change the base?

Adds Suitcase Device module #94

Conversation

Landric commented Jan 13, 2024 • edited

Crowdedlight commented Jan 17, 2024

Landric commented Jan 17, 2024 • edited

Crowdedlight commented Jan 17, 2024

Landric commented Jan 17, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Landric Feb 7, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Landric Feb 6, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Landric Feb 6, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Crowdedlight commented Jun 2, 2024

Landric commented Jun 3, 2024

Landric commented Jan 13, 2024 •

edited

Landric commented Jan 17, 2024 •

edited

Landric commented Jan 17, 2024 •

edited

Landric Feb 7, 2024 •

edited

Landric Feb 6, 2024 •

edited

Landric Feb 6, 2024 •

edited