Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment section #47

Merged
merged 11 commits into from
Jul 9, 2013
Merged

Add comment section #47

merged 11 commits into from
Jul 9, 2013

Conversation

mattlebel
Copy link
Contributor

Fixes issue #29 - Comment section.


.has_comments_input {
margin-top: 20px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to keep these field specific styles in the same order as those fields appear on the form...so you can put this css rule below the FAQ rules

@msaint
Copy link
Contributor

msaint commented Jul 9, 2013

Do we need to add any tests for this?

<div class="comment_content">
<div id="disqus_thread"></div>
<script type="text/javascript">
var disqus_shortname = '<%= raw(@campaign.has_comments_shortname).downcase %>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the 'raw' helper really necessary here?

@msaint
Copy link
Contributor

msaint commented Jul 9, 2013

COMMENTS!!!! :-)

👍 👍 👍

mattlebel added a commit that referenced this pull request Jul 9, 2013
@mattlebel mattlebel merged commit 8c14945 into master Jul 9, 2013
@mattlebel mattlebel deleted the disqus_final branch July 9, 2013 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants