Add support for status_date_filters to find_briefs #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidsg
reviewed
Jun 15, 2021
dmapiclient/data.py
Outdated
| ): | ||
| """ | ||
| The response will be paginated unless you provide user_id. | ||
|
|
||
| :param status_date_filters: contains additional status date filters. See the API for permitted keys. |
There was a problem hiding this comment.
Can we be any more specific about where these are listed/defined?
There are 18 possible status_date_filters, so we don't want to add them all individually. Instead allow users to provide a dictionary and let the API work out whether it's correct or not.
bjgill
force-pushed
the
status_date_filters
branch
from
a8eacff
to
dc0e4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/FGm8bi13/3-2-suppliers-may-be-missing-out-on-opportunities-due-to-misleading-banner
There are 18 possible status_date_filters, so we don't want to add them all individually. Instead allow users to provide a dictionary and let the API work out whether it's correct or not.
This should make a spot of analysis I'm trying to do a bit easier.