Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the version to the main index page when built #30

Merged
merged 2 commits into from
Feb 19, 2015

Conversation

tombye
Copy link
Contributor

@tombye tombye commented Feb 19, 2015

This was previously part of the task that pushed to Github pages, now part of the task that builds the pages.

Includes a fix to the README docs.

This was previously part of the task that pushed
to Github pages.
@quis
Copy link
Contributor

quis commented Feb 19, 2015

The only concern that I have: If you're working locally then the generated pages will display 'version 1.0.2'. What you will be seeing in the browser is v1.0.2 plus the effects of your local changes. Undecided as to whether that is an issue.

@tombye
Copy link
Contributor Author

tombye commented Feb 19, 2015

I think we have to bear it in mind for when we next add a feature and make a call on it then.

@quis
Copy link
Contributor

quis commented Feb 19, 2015

LGTM 👍 in that case. Preparing to merge…

@quis quis merged this pull request into master Feb 19, 2015
@quis quis deleted the bake-version-into-pages branch February 19, 2015 12:53
@tombye tombye restored the bake-version-into-pages branch February 23, 2015 14:53
quis added a commit that referenced this pull request Feb 23, 2015
@quis quis mentioned this pull request Feb 23, 2015
@quis quis deleted the bake-version-into-pages branch September 29, 2015 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants