Narrow left wide right #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a narrower column on the left moves the content closer to the heading. It's easier to read as most of the headings are short (which means there's a unnecessarily large white space between content and heading). It also gives a more comfortable line length for the content column which is mostly the thing you want to spend more time reading and this is much better when the content has bullet points as they are the thing that suffers most if they get wrapped onto two line. On the downside there are some lines where the heading wraps and the content is short, this makes the row taller, but not any harder to read. In most cases it will make the overall page longer, but only by a small amount and on pages that are already long (so users are already scrolling).
quis
added a commit
that referenced
this pull request
May 12, 2015
Includes: - #67 Narrow left wide right
Closed
quis
added a commit
to Crown-Commercial-Service/digitalmarketplace-supplier-frontend
that referenced
this pull request
May 12, 2015
quis
added a commit
to Crown-Commercial-Service/digitalmarketplace-supplier-frontend
that referenced
this pull request
May 12, 2015
quis
added a commit
to Crown-Commercial-Service/digitalmarketplace-supplier-frontend
that referenced
this pull request
May 15, 2015
quis
added a commit
to Crown-Commercial-Service/digitalmarketplace-supplier-frontend
that referenced
this pull request
May 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behaviour for tables to be 1/3 page width for headings and 2/3 for content.
Having a narrower column on the left moves the content closer to the heading. It's easier to read as most of the headings are short (which means there's a unnecessarily large white space between content and heading). It also gives a more comfortable line length for the content column which is mostly the thing you want to spend more time reading and this is much better when the content has bullet points as they are the thing that suffers most if they get wrapped onto two line. On the downside there are some lines where the heading wraps and the content is short, this makes the row taller, but not any harder to read. In most cases it will make the overall page longer, but only by a small amount and on pages that are already long (so users are already scrolling).
The old, non-default behaviour can be retained by changing to use the
.summary-item-field-name-widerclass.