Upgrade to postgres 10.15 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run the functional tests locally. Smoke tests all OK. Some of the full suite failed - now to see whether that's a pre-existing condition... |
|
Yes - the same tests failed on Postgres 9 and 10 because I didn't have a Notify key. I think this is good to go. |
lfdebrux
reviewed
Jan 6, 2021
| ports: | ||
| - "5432:5432" | ||
| volumes: | ||
| - ./sql:/docker-entrypoint-initdb.d | ||
| - postgres-data:/var/lib/postgresql/data | ||
| environment: | ||
| POSTGRES_USER: $USER | ||
| POSTGRES_HOST_AUTH_METHOD: trust |
There was a problem hiding this comment.
Argh - meant to break this out into a separate commit, but forgot. It's due to a change in the Docker container that now requires us to be explicit that we don't want a root password: docker-library/postgres#658
There was a problem hiding this comment.
I've amended the commit description to include this. Will now merge when green
lfdebrux
approved these changes
Jan 6, 2021
We need to upgrade to Postgres 12 by mid-February. We can't go directly, we need to go via Postgres 10 - https://docs.cloud.service.gov.uk/deploying_services/postgresql/#upgrade-to-postgresql-10. Upgrade dmrunner to use postgres 10 so we can test locally. After pulling this commit, you will need to run `make data` to re-initialise the database. We need to add `POSTGRES_HOST_AUTH_METHOD` because the postgres docker container has changed to require it: docker-library/postgres#658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/WdULXylT/2141-upgrade-postgresql
We need to upgrade to Postgres 12 by mid-February. We can't go directly, we need to go via Postgres 10 - https://docs.cloud.service.gov.uk/deploying_services/postgresql/#upgrade-to-postgresql-10.
Upgrade dmrunner to use postgres 10 so we can test locally. After pulling this commit, you will need to run
make datato re-initialise the database.