tab context menu disappears too soon if the title or favicon is (right-) clicked

[grahamperrin]

0.9.4 on Firefox 58.0 (64-bit) on FreeBSD-CURRENT.

1. right-click
2. observe the context menu
3. release

Expected

• a navigable menu

Actual result

• disappearance of the menu.

[Croydon]

@grahamperrin I either don't understand this report or I can't reproduce it.

The context menu should appear AFTER you release the right click and it should stay open till you click somewhere within the sidebar.

[grahamperrin]

Hi

… context menu should appear AFTER you release the right click …

To me, that's weird, I can't think of any application or extension that behaves in that way. I get the context menu on (not after) right-click.

[Croydon]

I believe it behaves differently on different operating systems.

Nevertheless, this issue is about the unexpecting disappearance of the context menu, right? So when exactly does it disappear?

Directly after it appears? When you click somewhere elese? After you begin to move the mouse?

[grahamperrin]

It seems quite random but as far as I can tell, the surest way to avoid the bug is to widen the (left) sidebar enough to have a gap between (a) the tail of the text of the title and (b) the right hand edge of the sidebar.

If I right-click in that space – avoiding the favicon and the text – the bug is not reproducible. The menu appears immediately, and does not disappear when I raise my finger (from the button of the mouse).

If I right-click on the text of the title, there's a very high likelihood of the bug biting: the menu disappears when I raise my finger (before I move the mouse).

---

If it helps to diagnose this bug: another peculiarity is, when the context menu does remain (allowing me to move the mouse without keeping a finger on the button), it does not disappear in response to Esc.

---

Also (and you might want a separate issue for this): if there's space beneath a tab (or beneath a stack of tabs), a right-click in that non-tab space misbehaves as if I'm clicking on a tab.

None of those issues occur with legacy 0.8.5.2.

[Croydon]

@grahamperrin Would you be willing to

• re-test this with the stable 0.10.0 release and if the error persists
• re-test this with the dev version: https://addons.mozilla.org/en-US/firefox/addon/vtr-developer-version/
  ?

I can neither reproduce this on Fedora/KDE nor under Windows 10.

[grahamperrin]

0.1.0 with Firefox 59.0.2_7,1 on FreeBSD-CURRENT: 2018-04-30 18:50.zip

[grahamperrin]

0.11.0a18: 2018-04-30 18:54.zip but ignore the first part of the screen recording, I accidentally had two versions enabled at the same time.

---

Looking at both screen recordings: it seems that disappearance of the menu is sometimes so quick that it's not captured in the recording.

[Croydon]

@grahamperrin Could you please verify that the problem is solved with 0.11.0a20+?

Edit: I realized that you might not be able to test anymore if you have only the release version of Firefox. I implemented in the meantime #176 which requires FF 60+ APIs. Do you have by any chance Firefox Beta / Nightly / Developer Version installed?

[grahamperrin]

Thanks, I have pre-release versions of Firefox on some systems, but not in everyday use. If I don't take a look later this week, I'll revisit this after 60 is released.

[Croydon]

@grahamperrin Thank you. I will close this issue soon, but I will re-open if you report that you still have the problem.

[grahamperrin]

0.11.0a22 with Firefox 60.0,1: not reproducible. Thanks for the fix!