Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One context menu instead of two #187

Open
grahamperrin opened this issue Apr 30, 2018 · 6 comments
Open

One context menu instead of two #187

grahamperrin opened this issue Apr 30, 2018 · 6 comments

Comments

@grahamperrin
Copy link

A frame from the screen recording at #171 (comment):

frame

It was difficult to get that traditional context menu, I'm not sure how I got it.

Is it possible for VTR context menu items to be appear as items in the traditional context menu?

@Croydon
Copy link
Owner

Croydon commented May 1, 2018

It was difficult to get that traditional context menu, I'm not sure how I got it.

If you right click really fast several times at the same spot the default context menu may appear. I'm not yet sure if I can prevent this somehow.

Is it possible for VTR context menu items to be appear as items in the traditional context menu?

Yes, but every add-on can only add one top-level-entry and everything else would be child elements like displayed in your screenshot by other add-ons. This would be completely impractical as you want to manage your tabs quickly, not always first open the child options.

@grahamperrin
Copy link
Author

… manage your tabs quickly …

Yep, but I don't want any single extension to preclude use of others.

In reality (when not occasionally testing things with Firefox Quantum) I'm accustomed to this:

2018-05-01 19 13 50

The child approach seems normal to me.

Maybe add a user preference?

@Croydon
Copy link
Owner

Croydon commented May 1, 2018

This context menu is the one from a default Firefox tab right?

The tabs in VTR's sidebar are custom elements, it's impossible to get the default tab context menu there, instead you would get the default website element context menu (i.e. not tab related options, but website related options).

This isn't helpful, is it?

By the way, there are open bugzilla bugs to demand further APIs to handle these situations better, but this is the current state.

@grahamperrin
Copy link
Author

Hi,

… from a default Firefox tab right? …

The shot was of a context menu for a tab of legacy Vertical Tabs Reloaded. So, "yes", I think :-)

… This isn't helpful, is it? …

LOL, no worries.

Does this add spice to the mix?

Custom Right-Click Menu – Add-ons for Firefox

@Croydon
Copy link
Owner

Croydon commented Oct 14, 2018

Add-ons will be able to have a shared context-menu in the near future for custom elements, thanks to browser.menus.overrideContext()

This will improve the situation overall for the context menu(s)

@Croydon
Copy link
Owner

Croydon commented Dec 12, 2018

Re-opening as a bug, even though this is out of my hands for now.

Will be fixed via #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants