Kotlin coroutines ReadWriteMutex #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asier to transition in the future
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
============================================
+ Coverage 35.48% 35.64% +0.16%
Complexity 485 485
============================================
Files 203 205 +2
Lines 4312 4337 +25
Branches 744 748 +4
============================================
+ Hits 1530 1546 +16
- Misses 2559 2568 +9
Partials 223 223
Continue to review full report at Codecov.
|
mattdrees
reviewed
Oct 8, 2020
...coroutines/src/test/java/org/ccci/gto/android/common/kotlin/coroutines/ReadWriteMutexTest.kt
Outdated
Show resolved
Hide resolved
mattdrees
approved these changes
Oct 8, 2020
...lin-coroutines/src/main/java/org/ccci/gto/android/common/kotlin/coroutines/ReadWriteMutex.kt
Outdated
Show resolved
Hide resolved
...lin-coroutines/src/main/java/org/ccci/gto/android/common/kotlin/coroutines/ReadWriteMutex.kt
Show resolved
Hide resolved
...lin-coroutines/src/main/java/org/ccci/gto/android/common/kotlin/coroutines/ReadWriteMutex.kt
Outdated
Show resolved
Hide resolved
we need to make sure we use the same owner between locking and unlocking the write lock from within multiple read locks.
`stateMutex` is purely used internally, so we don't need to pass in an arbitrary owner
|
Thanks for the thorough review @mattdrees you definitely caught some things that I missed |
|
You're welcome! And your fixes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Kotlin Coroutines doesn't have a native ReadWriteMutex yet. This implements one with basic functionality as a stop-gap solution until they provide an official one.
a
ReadWriteMutexshould function similarly to aReadWriteReentrantLock.This implementation doesn't address fairness for writers, so it is possible for readers to starve out waiting writers. but my current use-cases for this lock uses write access to perform background maintenance, and the background maintenance isn't critical for functionality, so it's alright if the writers are starved.
Relevant coroutines issue: Kotlin/kotlinx.coroutines#94