Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments Modal Improvements #369

Merged
merged 1 commit into from
May 21, 2015
Merged

Conversation

OzzieOrca
Copy link
Contributor

@adammeyer what do you think of this? Let me know if you have any issues or questions with the changes.

Changed/added:

  • Add registrant names to top of payments modal. Helpful to make certain you are entering payments for the right person and have clicked the right payments button.
  • Remove duplicate timestamps from payments tab when editing and made form fill entire width.
  • Fix spacing issue causing horizontal scrolling. This is the issue you messaged me about. Added col-xs-12 (https://github.com/CruGlobal/conf-registration-web/compare/responsive...payments-modal-improvements?expand=1#diff-0bf940ea2c79575d8a4dc75cbd019e4eR143) to add the 12px padding it needed for the form-group's -12px margin not to extend beyond the table
  • Changed step to 1 for currency values. (adjusting a payment/expense by cents doesn't make much sense.)
  • Made expenses tab editing happen inline. I think it makes it clearer what is being edited. Before the added row looked weird being a duplicate.

Other thoughts:

  • It might be nice to make the payments tab do inline editing also but there are several payment types that need lots of inputs. Could potentially do it inline for the ones with just a cost and description.

…rom payments tab when editing. Fix spacing issue causing horizontal scrolling. Changed <input type="number"> step to 1 for currency values. Made expenses tab editing happen inline.
<h4>Payments &amp; Expenses</h4>
<h4>Payments &amp; Expenses
<small>
<ng-pluralize count="registration.registrants.length" offset=2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@adammeyer
Copy link

Thanks @OzzieOrca. This looks great! The payments tab used to be editable inline but was changed when more fields where needed for scholarships and transfers. Didn't look right.

adammeyer pushed a commit that referenced this pull request May 21, 2015
@adammeyer adammeyer merged commit cbb481f into responsive May 21, 2015
@adammeyer adammeyer deleted the payments-modal-improvements branch May 21, 2015 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants