Modularize code for #36. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating master
Merging master
0x006E
reviewed
Sep 26, 2017
Listener.py
Outdated
| import json | ||
| import sys | ||
| from os.path import expanduser | ||
| from config.ConfigReader import ConfigurationReader |
0x006E
reviewed
Sep 26, 2017
Listener.py
Outdated
|
|
||
| # Twitter API credentials | ||
| cfg = {} | ||
| home = expanduser("~") |
There was a problem hiding this comment.
These lines are not needed in this file
0x006E
reviewed
Sep 26, 2017
main.py
Outdated
| import json | ||
| import sys | ||
| from os.path import expanduser | ||
| from config.ConfigReader import ConfigurationReader |
0x006E
reviewed
Sep 26, 2017
0x006E
approved these changes
Sep 26, 2017
|
Implemented changes as suggested in comments. |
|
@thakkardharmik What changes should be made in the setup.py? |
|
@nithinswarrier I think some changes would be required @ https://github.com/CruiseDevice/twweet-cli/blob/master/setup.py#L97 and |
|
@thakkardharmik merged 👍 ✨ 🎉 Sorry for merging this so late. I was busy with other commitments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the code. I need some help to modify setup.py in case the code looks fine. Also if someone can help me test the code.