Skip to content

Commit

Permalink
[#156801059]: Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
slobodan-ilic committed Jun 14, 2018
1 parent 36a3319 commit 5c88b39
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/cr/cube/crunch_cube.py
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,7 @@ def _margin_pruned_indices(margin, inserted_ind, axis):

@lazyproperty
def col_direction_axis(self):
axis = self.ndim - 2
return axis
return self.ndim - 2

@classmethod
def _fix_valid_indices(cls, valid_indices, insertion_index, dim):
Expand Down Expand Up @@ -1127,7 +1126,7 @@ def zscore(self, weighted=True, prune=False, hs_dims=None):
colsum = self.margin(axis=0, weighted=weighted, prune=prune)
rowsum = self.margin(axis=1, weighted=weighted, prune=prune)

if self.has_mr or 'categorical_array' in self.dim_types:
if self.has_mr or self.ca_dim_ind is not None:
if not self.is_double_mr and self.mr_dim_ind == 0:
total = total[:, np.newaxis]
rowsum = rowsum[:, np.newaxis]
Expand Down

0 comments on commit 5c88b39

Please sign in to comment.