[#177801573]: cr: ernesto's comments

* Add `weighted` to the test name * Remove weighted counts from one fixture, to demonstrate that the overlaps column proportions calculation still works (defaults to weighted counts)
Crunch-io · Apr 19, 2021 · 7fc056e · 7fc056e
1 parent 297a726
commit 7fc056e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 99 deletions.
diff --git a/tests/fixtures/overlaps/mr-x-mr.json b/tests/fixtures/overlaps/mr-x-mr.json
@@ -324,104 +324,6 @@
         ],
         "missing": 0,
         "measures": {
-            "count": {
-                "data": [
-                    3,
-                    0,
-                    0,
-                    2,
-                    1,
-                    0,
-                    0,
-                    3,
-                    0,
-                    0,
-                    2,
-                    0,
-                    1,
-                    1,
-                    0,
-                    0,
-                    2,
-                    0,
-                    0,
-                    0,
-                    1,
-                    1,
-                    0,
-                    0,
-                    0,
-                    1,
-                    0,
-                    2,
-                    1,
-                    1,
-                    4,
-                    0,
-                    0,
-                    0,
-                    4,
-                    0,
-                    1,
-                    1,
-                    0,
-                    0,
-                    2,
-                    0,
-                    0,
-                    2,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    3,
-                    2,
-                    1,
-                    4,
-                    2,
-                    0,
-                    0,
-                    6,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0,
-                    0
-                ],
-                "n_missing": 0,
-                "metadata": {
-                    "references": {},
-                    "derived": true,
-                    "type": {
-                        "integer": true,
-                        "missing_rules": {},
-                        "missing_reasons": {
-                            "No Data": -1
-                        },
-                        "class": "numeric"
-                    }
-                }
-            },
             "valid_overlap": {
                 "data": [
                     3,

diff --git a/tests/integration/test_pairwise_significance.py b/tests/integration/test_pairwise_significance.py
@@ -509,7 +509,7 @@ def test_pairwise_significance_mr_x_mr(self):
             nan_ok=True,
         )
 
-    def test_pairwise_cat_x_mr_gender_x_all_pets_owned(self):
+    def test_pairwise_cat_x_mr_gender_x_all_pets_owned_with_weighted_counts(self):
         slice_ = Cube(OL.CAT_X_MR_GENDER_X_ALL_PETS_OWNED).partitions[0]
 
         assert slice_.column_percentages.tolist() == pytest.approx(