Pre commit hooks 160906189 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percious
approved these changes
Oct 2, 2018
digitalresistor
suggested changes
Oct 3, 2018
setup.py
Outdated
| @@ -19,6 +19,7 @@ def get_long_desc(): | |||
| 'pytest', | |||
| 'pytest-cov', | |||
| 'mock', | |||
| 'pre-commit', | |||
There was a problem hiding this comment.
I don't think that this is something we should add to setup.py for this project. pre-commit is something the developer has to have installed on their machine globally, it is NOT a dependency of this project, not even a dev dependency IMHO.
- Add config file - Add dependency to testing
slobodan-ilic
force-pushed
the
pre-commit-hooks-160906189
branch
from
ec9d792
to
376fbc6
Compare
scanny
reviewed
Oct 12, 2018
digitalresistor
approved these changes
Oct 18, 2018
|
Excellent! This'll be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.