rfctr: move test fixtures to tests/fixtures #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move cube-response JSON from tests/integration/fixtures/cube to /tests/fixtures. * Add fixture lazy-loading.
|
@slobodan-ilic Can you CR this and merge at your earliest opportunity? It's pretty big (although simple) so it will be easier for both of us if we can base on this on master rather than have to do a merge/rebase onto it later. I'm happy to do the merge once you approve the CR, just let me know. |
| @@ -355,11 +346,7 @@ def test_array_x_mr_by_row(): | |||
|
|
|||
|
|
|||
| def test_array_x_mr_by_cell(): | |||
| cube = CrunchCube(ARRAY_X_MR) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move cube-response JSON from tests/integration/fixtures/cube to
/tests/fixtures.
Add fixture lazy-loading.