Fix population counts for Categorical Array, as 0th cube in tabbooks #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provide integration test that demonstrates existing bug * Fix the functionality by moving the key calculation to CubeSlice instead of CrunchCube, allowing each slice to control whether it is to be treated as a 0th element in tabbook array of cubes (slices)
slobodan-ilic
force-pushed
the
fix-pop-counts-for-ca-as-0th
branch
from
b3c975e
to
7b2e3dd
Compare
slobodan-ilic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of CrunchCube, allowing each slice to control whether it is to
be treated as a 0th element in tabbook array of cubes (slices)