Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate memoize from dimension.py #142

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Eliminate memoize from dimension.py #142

merged 2 commits into from
Mar 19, 2019

Conversation

slobodan-ilic
Copy link
Contributor

  • Make all_elements and valid_elements parts of the interface
  • Use newly available properties from CrunchCube
  • Fix unit tests

@coveralls
Copy link

coveralls commented Mar 19, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6318918 on lazyproperty-instead-of-memoize-in-dimension-164724176 into 12bf2e4 on master.

@slobodan-ilic
Eliminate memoize from Dimension.py
d7eaab0 
* Make `all_elements` and `valid_elements` parts of the interface
* Use newly available properties from `CrunchCube`
* Fix unit tests
@slobodan-ilic
Don't cover lru_cache in pytest
6318918
@slobodan-ilic slobodan-ilic force-pushed the lazyproperty-instead-of-memoize-in-dimension-164724176 branch from ad3fb3f to 6318918 Compare March 19, 2019 13:58
@slobodan-ilic slobodan-ilic merged commit 195855c into master Mar 19, 2019
@digitalresistor digitalresistor deleted the lazyproperty-instead-of-memoize-in-dimension-164724176 branch March 20, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slobodan-ilic @coveralls