rfctr: normalize and document #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No code changes, just reordering.
* Use "matrix" instead of "slice" for objects that contain row and column vectors and are used by the _Assembler object. We already use the term "slice" for the interface object and it's unnecessarily confusing to overload that name for a subordinate object. * Extract vector objects into vector module and matrix objects into matrix module, leaving core frozen-slice objects in slices module.
Create a factory for matrix-object construction in matrix module.
slobodan-ilic
approved these changes
May 23, 2019
|
Everything looks great. I'll merge and we can continue from master. We don't need a release just yet, probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalizing method order and documenting along the way of learning this new module.