Add cr.cube.cube.CubeSet #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented new class, and added it to the factory * All tests passing in `cr.cube` * Check how this affects exporter tests
Add responsibilities to CubeSet that were previously taken by the client side, further improving the encapsulation.
|
Hi Slobodan, can you CR this one and push a new release if it's okay? If you'll let me know the new release number I'll update the pin on the exporter side and then that branch can go on dev. |
slobodan-ilic
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cr.cube.cube.CubeSetwhich takes a full tabbook response set (multiple cube-responses) and provides table-wise partition sets and other appropriate properties characterizing the overall response-set.