fix: capture UserWarning in tests that trigger it #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ernestoarbitrio can you review this PR and merge it to master once approved? No release, just want to base the remaining work I'm doing on this so want it on master. |
The smoothing work generated a large number of UserWarning messages from tests that were not captured and therefore appeared as noise in the pytest output. Capture all of these and inspect them in each test to make sure the right one is being triggered. Correct several tests that were improperly emitting warnings or were emitting the wrong warning for the test case. Remove unnecessary fixtures for smoothing-failure cases because those can simply be checked against the unsmoothed output.
scanny
force-pushed
the
fix-smoothing-warnings
branch
from
4e33fcd
to
85edbe2
Compare
ernestoarbitrio
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoothing work generated a large number of UserWarning messages from tests that were not captured and therefore appeared as noise in the pytest output.
Capture all of these and inspect them in each test to make sure the right one is being triggered.
Correct several tests that were improperly emitting warnings or were emitting the wrong warning for the test case.
Remove unnecessary fixtures for smoothing-failure cases because those can simply be checked against the unsmoothed output.