Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#158907364]: Fix margin for 3D #82

Merged
merged 1 commit into from
Jul 11, 2018
Merged

[#158907364]: Fix margin for 3D #82

merged 1 commit into from
Jul 11, 2018

Conversation

slobodan-ilic
Copy link
Contributor

  • Don't deflate margin if first dimension has a single element and if
    the cube is 3D
  • The extra (0th) dimension is needed for proper slicing
  • Change expectation in the corresponding test

@slobodan-ilic
[#158907364]: Fix margin for 3D
b12882d 
- Don't deflate margin if first dimension has a single element and if
the cube is 3D
- The extra (0th) dimension is needed for proper slicing
- Change expectation in the corresponding test
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b12882d on single-subvar-ca-#158907364 into 0992f87 on master.

malecki
malecki approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@malecki malecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimension reduction is tricky! good catch

@crunchbot crunchbot merged commit b12882d into master Jul 11, 2018
@crunchbot crunchbot deleted the single-subvar-ca-#158907364 branch July 11, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malecki malecki malecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slobodan-ilic @coveralls @malecki @crunchbot