Configurable and very basic health check endpoint #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Health endpoint
|
Thank you, this passes for me, and is merged. |
pramsey
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Test show/hide preview functionality * Simple health check endpoint and tests --------- Co-authored-by: Eldan Goldenberg <eg@eldang.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this change is to address #131 .
It creates a simple endpoint, which only responds to
GETrequests. It responds with200 OKif the server up and running. By default, the endpoint is at/healthunder theBasePath, but you can set an alternative path for it using theHealthEndpointconfig key or the command-line flag-e.There was discussion of multiple endpoints in the issue, but I don't think I have the necessary context to decide when
startupversusreadinessones should return a 200. Also, it sounds like people may want to supply multiple alternate paths; I have left that for another day.While I was in there, I
postgisextension (in my case, it was because my test user didn't have permission). I don't know how common this scenario is, but it happened to me because I was starting the project up from scratch to take a look at making this change in particular.