feat(makefile): add docker buildx support #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awill1988
force-pushed
the
feat/multi-arch
branch
from
507575c
to
348bdb6
Compare
fix(cnf.mak.docker): fix argument parsing
awill1988
force-pushed
the
feat/multi-arch
branch
from
348bdb6
to
85b6c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes that
docker buildxhas been setup on the developer's machine.cnf.mak.docker
Introduces some logic to determine the arch and docker options and leave current Makefile behavior intact
Makefile
Add
buildx-dockerthat will compile multi-arch images. On MacOS, it took me about 2 minutes--pretty fast!Examples
make buildx-dockerwill push directly to the official imagemake buildx-docker USERNAME_OR_REGISTRY TAGUpdate
Fixed argument parsing for APPVERSION