Fixed RNG generating null-bytes in metadata; causing read errors. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow it was fast, thank you 馃榿 I will test it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Information
Summary
RNGCryptoService.GetNonZeroBytes()sometimes returning null bytes (for whatever reason)Changes and Descriptions
This bug fix simply ensures that
RNGCryptoService.GetNonZeroBytes()never generates a null byte (which corrupts the file metadata).I assume that's what was causing issue #14, it seemed to stop after I made these changes so I think I may have fixed it 馃槢
Please review my changes and make sure the bug is fixed 馃槃
Cheers!
-- h5p9sl