Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/99 - Updating to V2 and removing hardcoded GetColumns values #109

Merged
merged 34 commits into from Feb 26, 2019

Conversation

neocybereth
Copy link
Contributor

No description provided.

@neocybereth neocybereth changed the title Feat/99 getcolumn conseil metadata Feat/99 - Updating to V2 and removing hardcoded GetColumns values Feb 19, 2019
@umurb umurb changed the base branch from develop to master February 22, 2019 15:02
@umurb umurb changed the base branch from master to develop February 22, 2019 15:02
@@ -144,57 +157,139 @@ class Arronax extends React.Component<Props, States> {
switch (value) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When change tab, we should not initialize the selected columns.

@developer0623
Copy link
Contributor

developer0623 commented Feb 22, 2019

@Sm00g15 I think it is better to use selectedColumns and network of customTable component in CustomTableRow component.

@neocybereth
Copy link
Contributor Author

neocybereth commented Feb 24, 2019

@Sm00g15 I think it is better to use selectedColumns and network of customTable component in CustomTableRow component.

Awesome @developer0623 , I took your advice and that's been implemented.

@umurb umurb merged commit 6190278 into develop Feb 26, 2019
@neocybereth neocybereth deleted the feat/99-getcolumn-ConseilMetadata branch March 24, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants