feature/ethereum refactor accounts table #983
Conversation
…ory and transactions tables
redroy44
force-pushed
the
feature/ethereum-refactor-accounts-table
branch
from
30b7a4d
to
1923764
Compare
…factor-accounts-table
| implicit ec: ExecutionContext | ||
| ): DBIOAction[List[Unit], NoStream, Effect.Read with Effect.Write with Effect.Transactional] = { | ||
| import tech.cryptonomic.conseil.common.sql.CustomProfileExtension.api._ | ||
| DBIO.sequence( |
There was a problem hiding this comment.
Maybe I don't understand something, but why didn't you use something like this: Tables.Accounts.insertOrUpdateAll(accounts.map(_.convertTo[Tables.AccountsRow]))?
There was a problem hiding this comment.
Basically I want to update Account with the latest data (blockHash, blockNumber, timestamp, balance) without overwriting contract/token data (bytecode, bytecode_hash, token_standard, name, symbol, decimals, total_supply)
That's why I take the existing row, update a subset of fields and write the updated row to DB
| */ | ||
| def createTokens(tokens: List[Token]) = | ||
| def createAccountBalances(accounts: List[Account]): DBIOAction[Unit, NoStream, Effect.Write] = |
There was a problem hiding this comment.
I believe this also works - a bit cleaner:
def createAccountBalances(accounts: List[Account]): DBIO[Option[Int]] =
Tables.AccountsHistory ++= accounts.map(_.convertTo[Tables.AccountsHistoryRow])
| */ | ||
| def createContracts(contracts: List[Contract]) = | ||
| def createContractAccounts(contractAccounts: List[Account]): DBIOAction[Unit, NoStream, Effect.Write] = |
There was a problem hiding this comment.
can you refactor this like in example for createAccountBalances ?
|
Kudos, SonarCloud Quality Gate passed!
|
To be merged to master after #981
This PR brings a number of ethereum improvements:
(block_hash, block_number, timestamp)wherever necessarylog_indextotoken_transferstable for orderingaccountstable to contain account, contract and token dataaccounts_historytable for temporal queries along with accounts_history endpointcontractsandtokensas views ofaccountstabletokenStandardinstead ofisERC20andisERC721fields