ConseilJS 5.0.2-beta.3 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymoussprocket
requested review from
vishakh,
dariuszsobkowicz,
PrathamRawat and
Taaseen-Ali
vishakh
requested changes
Jun 26, 2020
| * Returns a value for a given key. The big map id is either provided as a paramter or the smallest of the possibly multiple big maps associated with the given contract address is used. Note that sometimes key values must be wrapped in quotes for key types that are non-numeric and not byte type. | ||
| * | ||
| * @param serverInfo Conseil server connection definition. | ||
| * @param key Key to query for. |
There was a problem hiding this comment.
We should specify whether this is encoded or not.
There was a problem hiding this comment.
docs were updated
|
|
||
| let contentQuery = ConseilQueryBuilder.setLimit(ConseilQueryBuilder.blankQuery(), 1); | ||
| contentQuery = ConseilQueryBuilder.addFields(contentQuery, 'value'); | ||
| contentQuery = ConseilQueryBuilder.addPredicate(contentQuery, 'key', ConseilOperator.EQ, [key], false); |
There was a problem hiding this comment.
Is it not possible to automatically encode the key? I forget the details.
There was a problem hiding this comment.
not at this time, contract parser will need updates.
vishakh
previously approved these changes
Jul 4, 2020
dariuszsobkowicz
approved these changes
Jul 6, 2020
vishakh
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes