Allow Estimation of Multiple Operations #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2020_audit Add July 2020 audit report
keefertaylor
changed the title
|
I believe CI is failing due to unrelated reasons, please advise if this is not the case. |
anonymoussprocket
approved these changes
Jul 29, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, operations are dependent on a prior operation (ie. a reveal must be sent before a transfer can be made). Expose an API that allows users to estimate operations atomically.
A possible optimization is to automatically prepend reveal operations in the
estimateOperationmethod. Since that is likely a breaking change in Conseil functionality, I have omitted it for simplicity.