Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize StakerDao's Tzip 7 #336

Merged

Conversation

keefertaylor
Copy link
Contributor

@keefertaylor keefertaylor commented Nov 30, 2020

Generalize StakerDAO's Tzip 7 Implementation for re-use.

The ultimate goal is to provide a wrapper for BLND which uses the same token contract as WXTZ.

To accomplish this:

  • Refactor token based functionality to a new helper file, and rename
  • Convert namespace declarations to objects. This should be functionally the same to the client and there is no good way to merge namespaces (As far as this humble typescript developer can tell)
  • Export a merged object of token functionality and wrapped tezos functionality. Note that object props after && override the former. Ex:
const a = {
  foo: function() { return "A" }
}

const b = {
  foo: function() { return "B" }
}

const c = a && b

a.foo() // "A"
b.foo() // "B"
c.foo() // "B"

Note: Please merge after #335. There's no way to diffbase this branch on this PR.

@keefertaylor keefertaylor changed the title [Experimental] Generalize StakerDao's Tzip 7 Generalize StakerDao's Tzip 7 Nov 30, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anonymoussprocket anonymoussprocket merged commit f3e2067 into Cryptonomic:release/505 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants